[WBT] enable coreCLR by pavelsavara · Pull Request #124850 · dotnet/runtime

pavelsavara · 2026-02-25T09:27:37Z

drop WasmBrowserRunMainOnly
add [TestCategory("native")] as necessary
always expect dotnet.diagnostics.js on CoreCLR
disable native trait for CoreCLR run
split off AOT tests

Passing: 59 Failing: 27

Copilot

Pull request overview

This pull request enables CoreCLR runtime testing in the WASM Build Tests suite by categorizing tests and filtering them appropriately based on the runtime flavor. The PR removes a CoreCLR-specific test asset that is no longer needed and ensures that tests requiring native builds, Mono-specific features, or workload installations are properly excluded when running with CoreCLR.

Changes:

Removed the WasmBrowserRunMainOnly test asset and test class, which was specifically created for CoreCLR but is no longer needed
Added TestCategory attributes to categorize tests as "native" (requiring AOT/native builds), "mono" (Mono-specific features), or "workload" (requiring workload installation)
Updated test filtering logic in Wasm.Build.Tests.csproj to exclude native/mono/workload tests when running with CoreCLR runtime
Modified WasmSdkBasedProjectProvider to expect diagnostics files for CoreCLR builds

Reviewed changes

Copilot reviewed 46 out of 46 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/mono/wasm/testassets/WasmBrowserRunMainOnly/*	Deleted entire test asset directory (6 files) that was specific to CoreCLR testing
src/mono/wasm/Wasm.Build.Tests/WasmBrowserRunMainOnly.cs	Deleted CoreCLR-specific test class
src/mono/wasm/Wasm.Build.Tests/BrowserStructures/TestAsset.cs	Removed WasmBrowserRunMainOnly test asset reference
src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj	Updated XUnit trait filtering to exclude native/mono/workload categories for CoreCLR
src/mono/wasm/Wasm.Build.Tests/WasmSdkBasedProjectProvider.cs	Added logic to expect diagnostics.js files for CoreCLR builds
src/mono/wasm/Wasm.Build.Tests/WorkloadTests.cs	Added "native" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/WasmBuildAppTest.cs	Added "native" category to AOT test methods
src/mono/wasm/Wasm.Build.Tests/WasmSIMDTests.cs	Added "native" category to PublishSIMD_AOT test
src/mono/wasm/Wasm.Build.Tests/WasmNativeDefaultsTests.cs	Added "native" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs	Added "workload" and "native" categories to various template tests
src/mono/wasm/Wasm.Build.Tests/Templates/NativeBuildTests.cs	Added "native" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/SatelliteAssembliesTests.cs	Added "native" category to resource assembly tests
src/mono/wasm/Wasm.Build.Tests/PInvokeTableGeneratorTests.cs	Added "native" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/NativeRebuildTests/*	Added "native" category to all native rebuild test classes (5 files)
src/mono/wasm/Wasm.Build.Tests/NativeLibraryTests.cs	Added "native" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/NativeBuildTests.cs	Added "native" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/ModuleConfigTests.cs	Split SymbolMapFileEmitted test into two separate tests, marking only the emitting case as "native"
src/mono/wasm/Wasm.Build.Tests/MemoryTests.cs	Added "native" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs	Added "native" category to main-with-args tests
src/mono/wasm/Wasm.Build.Tests/InvariantTimezoneTests.cs	Added "native" category to invariant timezone tests
src/mono/wasm/Wasm.Build.Tests/InvariantGlobalizationTests.cs	Added "native" category to invariant globalization tests
src/mono/wasm/Wasm.Build.Tests/InterpPgoTests.cs	Added "mono" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/IcuTests.cs	Added "native" and "workload" categories to ICU tests
src/mono/wasm/Wasm.Build.Tests/IcuShardingTests*.cs	Added "native" category to ICU sharding tests (2 files)
src/mono/wasm/Wasm.Build.Tests/DllImportTests.cs	Added "native" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/DiagnosticsTests.cs	Added "mono" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/BuildPublishTests.cs	Added "native" category to AOT publish tests
src/mono/wasm/Wasm.Build.Tests/Blazor/*	Added "native" and "mono" categories to various Blazor tests (8 files)

Copilot

Pull request overview

Copilot reviewed 49 out of 49 changed files in this pull request and generated 3 comments.

eng/pipelines/global-build.yml

eng/pipelines/runtime-linker-tests.yml

src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj

Copilot

Pull request overview

Copilot reviewed 50 out of 50 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 51 out of 51 changed files in this pull request and generated 1 comment.

eng/testing/scenarios/BuildWasmAppsJobsListCLR.txt

pavelsavara · 2026-02-26T07:24:59Z

we can update this branch and try to add back the lazy loading, I just merged it

Copilot

Pull request overview

Copilot reviewed 50 out of 50 changed files in this pull request and generated 1 comment.

Copilot · 2026-02-26T07:37:10Z

src/libraries/sendtohelix-wasm.targets

+      <HelixWorkItem Include="@(BuildWasmApps_PerJobList->'$(WorkItemPrefix)%(Identity)')" Condition="'$(RuntimeFlavor)' == 'CoreCLR' and '$(WasmFingerprintAssets)' == 'true' and '$(WasmBundlerFriendlyBootConfig)' == 'false'">
        <PayloadArchive>$(_BuildWasmAppsPayloadArchive)</PayloadArchive>
        <PreCommands>$(EnvVarCommand) &quot;HELIX_XUNIT_ARGS=-class %(Identity)&quot;</PreCommands>
        <Command>$(HelixCommand)</Command>


The new per-class CoreCLR work item condition relies on $(WasmFingerprintAssets) == 'true', but in CoreCLR BuildWasmApps this property may be empty (not explicitly set) even though fingerprinting defaults to enabled in the SDK/RunScriptTemplate. That would prevent these per-class items from being created, making BuildWasmAppsJobsListCLR.txt unused. Also, if WasmFingerprintAssets is set to true for CoreCLR in the future, ensure the existing fallback Wasm.Build.Tests work item (below) is suppressed to avoid running both the per-class items and the full suite.

ilonatommy · 2026-02-26T11:58:46Z

Summary:

Test Class	Result	Error Text	Comments	Issue
AppSettingsTests	0/8	`'/appsettings.json' exists 'False'`	CoreCLR doesn't bundle appsettings files	#124895
DebugLevelTests	14/14
DownloadThenInitTests	0/2		CoreCLR can't re-init native module	#124896
EnvVariablesTests	1/1
FilesToIncludeInFileSystemTests	2/2
HttpTests	2/2
LazyLoadingTests	1/4	`The lazy loading test didn't load PDB`	CoreCLR WASM does not load PDBs for lazy-loaded assemblies; runtime pack needs update to support this.	#124898
LibraryInitializerTests	0/2	LoadLibraryInitializer: empty collection (initializer not called); AbortStartupOnError: WASM EXIT timeout	`EnableDiagnostics=true` does not fix it	#124899
MaxParallelDownloadsTests	0/2	Active downloads exceeded the limit (2 > 1, 5 > 4)	Download throttling logic not enforced	#124900
ModuleConfigTests	4/8	DownloadProgressFinishes: WASM EXIT timeout; OutErrOverrideWorks: override failed; OverrideBootConfigName: not supported
PreloadingTests	8/8
RebuildTests	1/1
SatelliteLoadingTests	2/4	Assert.Equal() Failure: Strings differ (expected: "es-ES with satellite: hola", actual: "es-ES with satellite: hello")	Satellite resource loading returns wrong string for es-ES; CoreCLR does not load correct satellite resources	#124901
WasmBuildAppTest	8/8
WasmRunOutOfAppBundleTests	2/2
WasmTemplateTests	1/1

…romMyException", without "error".

Copilot

Pull request overview

Copilot reviewed 53 out of 53 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/libraries/sendtohelix-wasm.targets:70

For RuntimeFlavor=CoreCLR the per-class HelixWorkItem is created even when TestUsingWorkloads=false, but the aggregate Wasm.Build.Tests work item is also created because its condition includes $(TestUsingWorkloads) != 'true'. This will schedule the same tests twice in CoreCLR BuildWasmApps jobs. Update the conditions so CoreCLR runs either the per-class work items or the aggregate work item, but not both (e.g., gate the CoreCLR per-class items on TestUsingWorkloads=='true', or exclude RuntimeFlavor=CoreCLR from the aggregate condition when per-class splitting is enabled).

      <HelixWorkItem Include="@(BuildWasmApps_PerJobList->'$(WorkItemPrefix)%(Identity)')" Condition="'$(RuntimeFlavor)' == 'CoreCLR' and '$(WasmFingerprintAssets)' == 'true' and '$(WasmBundlerFriendlyBootConfig)' == 'false'">
        <PayloadArchive>$(_BuildWasmAppsPayloadArchive)</PayloadArchive>
        <PreCommands>$(EnvVarCommand) &quot;HELIX_XUNIT_ARGS=-class %(Identity)&quot;</PreCommands>
        <Command>$(HelixCommand)</Command>
        <Timeout>$(_workItemTimeout)</Timeout>
      </HelixWorkItem>

      <HelixWorkItem Include="$(WorkItemPrefix)Wasm.Build.Tests" Condition="'$(TestUsingWorkloads)' != 'true' or '$(WasmFingerprintAssets)' != 'true' or '$(WasmBundlerFriendlyBootConfig)' != 'false'">
        <PayloadArchive>$(_BuildWasmAppsPayloadArchive)</PayloadArchive>
        <Command>$(HelixCommand)</Command>
        <Timeout>$(_workItemTimeout)</Timeout>
      </HelixWorkItem>

Copilot · 2026-02-26T14:22:25Z

src/mono/wasm/testassets/WasmBasicTestApp/App/wwwroot/main.js

        case "DotnetRun":
        case "MainWithArgs":
-            dotnet.run();
+            dotnet.runMainAndExit();
            break;


dotnet.runMainAndExit() is invoked without await. Other call sites in this repo await runMainAndExit (it returns a Promise), and not awaiting here can let the script fall through without proper error/exit propagation for these scenarios. Please await the call (and ensure the switch case exits afterward if needed).

src/libraries/sendtohelix-browser.targets

Copilot

Pull request overview

Copilot reviewed 56 out of 56 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/libraries/sendtohelix-wasm.targets:64

The CoreCLR work item condition on line 59 does not check for TestUsingWorkloads like the Mono condition on line 52 does. This means CoreCLR tests will run even when TestUsingWorkloads is 'false', while Mono tests require workloads. Is this intentional? If CoreCLR WASM requires workloads to function, the condition should include the same '$(TestUsingWorkloads)' == 'true' check. Otherwise, the test could fail in non-workload scenarios for CoreCLR.

      <HelixWorkItem Include="@(BuildWasmApps_PerJobList->'$(WorkItemPrefix)%(Identity)')" Condition="'$(RuntimeFlavor)' == 'CoreCLR' and '$(WasmFingerprintAssets)' == 'true' and '$(WasmBundlerFriendlyBootConfig)' == 'false'">
        <PayloadArchive>$(_BuildWasmAppsPayloadArchive)</PayloadArchive>
        <PreCommands>$(EnvVarCommand) &quot;HELIX_XUNIT_ARGS=-class %(Identity)&quot;</PreCommands>
        <Command>$(HelixCommand)</Command>
        <Timeout>$(_workItemTimeout)</Timeout>
      </HelixWorkItem>

src/mono/wasm/Wasm.Build.Tests/WasmBuildAppTest.cs

eng/testing/scenarios/BuildWasmAppsJobsListCoreCLR.txt

Copilot

Pull request overview

Copilot reviewed 56 out of 56 changed files in this pull request and generated 1 comment.

Copilot · 2026-02-26T20:07:49Z

src/libraries/sendtohelix-browser.targets

  <PropertyGroup Condition="'$(Scenario)' == 'BuildWasmApps'">
-    <BuildWasmAppsJobsList>$(RepositoryEngineeringDir)testing\scenarios\BuildWasmAppsJobsList.txt</BuildWasmAppsJobsList>
+    <BuildWasmAppsJobsList Condition="'$(RuntimeFlavor)' == 'Mono'">$(RepositoryEngineeringDir)testing\scenarios\BuildWasmAppsJobsList.txt</BuildWasmAppsJobsList>
+    <BuildWasmAppsJobsList Condition="'$(RuntimeFlavor)' == 'CoreCLR'">$(RepositoryEngineeringDir)testing\scenarios\BuildWasmAppsJobsListCLR.txt</BuildWasmAppsJobsList>


BuildWasmAppsJobsList for CoreCLR points to BuildWasmAppsJobsListCLR.txt, but the repo contains eng/testing/scenarios/BuildWasmAppsJobsListCoreCLR.txt (and no ...CLR.txt). With the current path, ReadLinesFromFile in sendtohelix-wasm.targets will never run and CoreCLR BuildWasmApps work items won’t get split per test class. Update the filename here to match the added jobs list file.

Suggested change

<BuildWasmAppsJobsList Condition="'$(RuntimeFlavor)' == 'CoreCLR'">$(RepositoryEngineeringDir)testing\scenarios\BuildWasmAppsJobsListCLR.txt</BuildWasmAppsJobsList>

<BuildWasmAppsJobsList Condition="'$(RuntimeFlavor)' == 'CoreCLR'">$(RepositoryEngineeringDir)testing\scenarios\BuildWasmAppsJobsListCoreCLR.txt</BuildWasmAppsJobsList>

pavelsavara added 2 commits February 25, 2026 10:25

drop WasmBrowserRunMainOnly

4a3cbb0

wip

8e8806c

pavelsavara added this to the 11.0.0 milestone Feb 25, 2026

pavelsavara self-assigned this Feb 25, 2026

Copilot AI review requested due to automatic review settings February 25, 2026 09:27

pavelsavara added arch-wasm WebAssembly architecture area-Infrastructure-coreclr os-browser Browser variant of arch-wasm labels Feb 25, 2026

github-project-automation bot added this to Runtime Infra Feb 25, 2026

Copilot started reviewing on behalf of pavelsavara February 25, 2026 09:28 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

pavelsavara requested a review from radekdoulik February 25, 2026 10:01

ilonatommy added 2 commits February 25, 2026 11:46

TMP: shorten the dev loop, disable lanes that we're not fixing.

10c3308

Enable WBT for CoreCLR.

16535e5

Copilot AI review requested due to automatic review settings February 25, 2026 10:49

Copilot started reviewing on behalf of ilonatommy February 25, 2026 10:50 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

eng/pipelines/global-build.yml Outdated Show resolved Hide resolved

eng/pipelines/runtime-linker-tests.yml Outdated Show resolved Hide resolved

src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj Show resolved Hide resolved

Remove TMP changes.

0b92d26

build-analysis bot mentioned this pull request Feb 25, 2026

[android][clr] No peer certificates when executing System.Net.Http.Functional.Tests on Android emulator #124526

Open

job list for coreCLR

3bc6c76

Copilot AI review requested due to automatic review settings February 25, 2026 16:35

Copilot started reviewing on behalf of pavelsavara February 25, 2026 16:36 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

build-analysis bot mentioned this pull request Feb 25, 2026

Wasm build terminated with exit code 137 #108299

Open

Fix 0 tests matched on CI.

e7f36c4

Copilot started reviewing on behalf of ilonatommy February 26, 2026 07:10 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

eng/testing/scenarios/BuildWasmAppsJobsListCLR.txt Show resolved Hide resolved

Feedback: better exclusion.

be5b8a1

Merge branch 'main' into wbt_coreclr

760be21

Copilot AI review requested due to automatic review settings February 26, 2026 07:28

Re-enable lazy loading.

93ee02b

Copilot started reviewing on behalf of ilonatommy February 26, 2026 07:29 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

build-analysis bot mentioned this pull request Feb 26, 2026

Unable to pull image from mcr.microsoft.com #117164

Open

ilonatommy added 5 commits February 26, 2026 13:33

Fix: timeouts waiting for 'WASM EXIT' message.

9165e9c

Coreclr's message is "Unhandled exception. System.Exception: MessageF…

e137e32

…romMyException", without "error".

Block AppSettingsTests -> CoreCLR doesn't bundle appsettings files.

ad337a3

Disable tests we opened issues for.

d3e3fd4

Block remaining tests that are logged as issues.

61178e4

Copilot AI review requested due to automatic review settings February 26, 2026 14:13

Copilot started reviewing on behalf of ilonatommy February 26, 2026 14:14 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

ilonatommy added 2 commits February 26, 2026 20:37

Not skip but conditional theroy/fact.

4532a9d

Apply copilot's feedback to fix CI.

ec03bb8

Copilot AI review requested due to automatic review settings February 26, 2026 19:42

Copilot started reviewing on behalf of ilonatommy February 26, 2026 19:43 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

src/mono/wasm/Wasm.Build.Tests/WasmBuildAppTest.cs Show resolved Hide resolved

maraf reviewed Feb 26, 2026

View reviewed changes

eng/testing/scenarios/BuildWasmAppsJobsListCoreCLR.txt Show resolved Hide resolved

ilonatommy added 2 commits February 26, 2026 21:00

Rename.

ee03e6c

Fix rename...

2b1efbe

Copilot AI review requested due to automatic review settings February 26, 2026 20:01

Copilot started reviewing on behalf of ilonatommy February 26, 2026 20:02 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

	<BuildWasmAppsJobsList Condition="'$(RuntimeFlavor)' == 'CoreCLR'">$(RepositoryEngineeringDir)testing\scenarios\BuildWasmAppsJobsListCLR.txt</BuildWasmAppsJobsList>
	<BuildWasmAppsJobsList Condition="'$(RuntimeFlavor)' == 'CoreCLR'">$(RepositoryEngineeringDir)testing\scenarios\BuildWasmAppsJobsListCoreCLR.txt</BuildWasmAppsJobsList>

Conversation

pavelsavara commented Feb 25, 2026 • edited by ilonatommy Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

pavelsavara commented Feb 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

ilonatommy commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pavelsavara commented Feb 25, 2026 •

edited by ilonatommy

Loading

ilonatommy commented Feb 26, 2026 •

edited

Loading